develooper Front page | perl.perl5.porters | Postings from August 2002

RE: [perl #15869] perl 5.8.0

Thread Previous
From:
Paul Marquess
Date:
August 3, 2002 06:53
Subject:
RE: [perl #15869] perl 5.8.0
Message ID:
AIEAJICLCBDNAAOLLOKLKEKIFCAA.Paul.Marquess@btinternet.com
From: Daniel R. Grayson (via RT) [mailto:perlbug@perl.org]

> # New Ticket Created by  "Daniel R. Grayson"
> # Please include the string:  [perl #15869]
> # in the subject line of all future correspondence about this issue.
> # <URL: http://rt.perl.org/rt2/Ticket/Display.html?id=15869 >
>
>
>
> To fix this:
>
>     cc -c   -fno-strict-aliasing -D_LARGEFILE_SOURCE
> -D_FILE_OFFSET_BITS=64 -O3   -DVERSION=\"1.804\"
> -DXS_VERSION=\"1.804\" -fpic "-I../.."   DB_File.c
>     DB_File.xs: In function `ParseOpenInfo':
>     DB_File.xs:1370: warning: passing arg 2 of pointer to
> function from incompatible pointer type
>     DB_File.xs:1370: incompatible type for argument 4 of indirect
> function call
>     DB_File.xs:1370: too few arguments to function
>
> I tried this change:
>
>     diff -ur tmp/perl-5.8.0/ext/DB_File/DB_File.xs
> perl-5.8.0/ext/DB_File/DB_File.xs
>     --- tmp/perl-5.8.0/ext/DB_File/DB_File.xs	2002-06-01
> 12:02:53.000000000 -0500
>     +++ perl-5.8.0/ext/DB_File/DB_File.xs	2002-07-30
> 21:11:50.000000000 -0500
>     @@ -1366,7 +1366,7 @@
> 		 Flags |= DB_TRUNCATE ;
>      #endif
>
>     -        status = (RETVAL->dbp->open)(RETVAL->dbp, name,
> NULL, RETVAL->type,
>     +        status = (RETVAL->dbp->open)(RETVAL->dbp, (DB_TXN
> *)0, name, NULL, RETVAL->type,
> 				    Flags, mode) ;
> 	    /* printf("open returned %d %s\n", status,
> db_strerror(status)) ; */
>
> which seemed to help.  Was it the right thing to do?

Are you running a beta of Berkeley DB 4.1?

If so, that fix is fine. My development copy of DB_File does more or less
the same thing, but allows DB_File to still be build with older versions of
Berkeley DB. I'll be releasing DB_File 1.805 with the fix sometime soon.

Paul


Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About